Skip to content

Move Step ref tests to container_validation_test.go. #8772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

Move Step ref tests to container_validation_test.go. #8772

merged 1 commit into from
Jun 12, 2025

Conversation

@twoGiants
Copy link
Member

@twoGiants twoGiants commented May 15, 2025 •
edited
Loading

Changes

Now that Step implements the Validatable interface the tests for the Step validation are moved from task_validation_test.go to container_validation_test.go.

The following two tests are moved and renamed:

  • TestTaskSpecValidateErrorWithStepActionRef
    • to TestStepValidateErrorWithStepActionRef

This PR is one of a series to migrate the tests in small batches so that they are easier to review.

More details are in issue #8700.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 15, 2025
@tekton-robot tekton-robot requested review from afrittoli and jerop May 15, 2025 10:48
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 15, 2025
@twoGiants twoGiants mentioned this pull request May 14, 2025
Closed
25 tasks
@twoGiants
Copy link
Member Author

twoGiants commented May 15, 2025

/kind cleanup

@tekton-robot
Copy link
Collaborator

tekton-robot commented May 15, 2025

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 99.1% 99.1% 0.0

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2025
@twoGiants twoGiants force-pushed the issue-8700-move-step-ref-tests branch from 0e1d8e9 to 160d185 Compare May 22, 2025 10:57
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2025
@twoGiants twoGiants force-pushed the issue-8700-move-step-ref-tests branch from 160d185 to a6750b7 Compare May 22, 2025 10:58
@twoGiants twoGiants changed the title 🚧 Move Step ref tests to container_validation_test.go. 🚧 Move Step ref tests to container_validation_test.go. May 22, 2025
@twoGiants twoGiants marked this pull request as ready for review May 22, 2025 11:01
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2025
@tekton-robot tekton-robot requested review from dibyom and vdemeester May 22, 2025 11:01
@twoGiants
Copy link
Member Author

twoGiants commented Jun 3, 2025

/ok-to-test

@tekton-robot tekton-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 3, 2025
@twoGiants
Copy link
Member Author

twoGiants commented Jun 3, 2025

/retest

1 similar comment
@afrittoli
Copy link
Member

afrittoli commented Jun 9, 2025

/retest

afrittoli
afrittoli reviewed Jun 9, 2025
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link
Collaborator

tekton-robot commented Jun 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 9, 2025
@twoGiants twoGiants force-pushed the issue-8700-move-step-ref-tests branch from a6750b7 to 40ea551 Compare June 12, 2025 13:26
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2025
@twoGiants
refactor: move Step Ref tests
511387b 
Now that `Step` implements the `Validatable` interface the tests for the
`Step` validation are moved from `task_validation_test.go` to
`container_validation_test.go`.

The following two tests are moved and renamed:
- `TestTaskSpecValidateErrorWithStepActionRef`
  - > `TestStepValidateErrorWithStepActionRef`

Issue tektoncd#8700.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
@twoGiants twoGiants force-pushed the issue-8700-move-step-ref-tests branch from 40ea551 to 511387b Compare June 12, 2025 13:28
@vdemeester
Copy link
Member

vdemeester commented Jun 12, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2025
@tekton-robot tekton-robot merged commit fb60939 into tektoncd:main Jun 12, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afrittoli afrittoli afrittoli left review comments

@jerop jerop Awaiting requested review from jerop

@dibyom dibyom Awaiting requested review from dibyom

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vdemeester vdemeester

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Tekton Community Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@twoGiants @tekton-robot @afrittoli @vdemeester